Skip to content

skip return true if the end of the stream is reached#3242

Merged
chenBright merged 2 commits intoapache:masterfrom
x1wan:bugfix/deserialize_skip_fail
Mar 16, 2026
Merged

skip return true if the end of the stream is reached#3242
chenBright merged 2 commits intoapache:masterfrom
x1wan:bugfix/deserialize_skip_fail

Conversation

@x1wan
Copy link
Contributor

@x1wan x1wan commented Mar 11, 2026

What problem does this PR solve?

Issue Number: 3207

Problem Summary: ParsePbFromIOBuf fail when skip reach the end of the stream

What is changed and the side effects?

Changed: skip return true if the end of the stream is reached

Side effects:

  • Performance effects: no effect

  • Breaking backward compatibility: no


Check List:

@wwbmmm
Copy link
Contributor

wwbmmm commented Mar 11, 2026

LGTM

Copy link
Contributor

@chenBright chenBright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenBright chenBright merged commit 0565d8d into apache:master Mar 16, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

客户端服务端proto不一致的情况下,ParsePbFromIOBuf 会稳定小概率反序列化解析失败

3 participants